mirror of
https://github.com/MobileGL-Dev/MobileGL
synced 2026-11-07 18:13:23 +09:00
swung0x48
aba329cc53
Two things land together: the plan and contract draft P6 needs before it starts, and the
working notes that until now existed on exactly one machine.
1. P6's plan and contract draft (neither started; not one line of code)
docs/Disaggregated/P6-SPAWN-PLAN.md the package plan
docs/Disaggregated/P6-CONTRACT-DRAFT.md the contract draft (moves to
MG_Remote/CONTRACT-P6.md when c6 lands)
The three findings that mattered, all written into the documents:
a. P6 is SMALLER than its roadmap cell suggests. The transport primitives are already in
the tree and already tested: SocketDoorbell including hangup detection and the two
lost-wakeup fences (Doorbell.cpp:211-360, four cases in FdPassingTest), SCM_RIGHTS fd
passing, ShmSegment::Adopt, and the SurfaceOp / WindowKind schema already defined in
protocol.fbs. inproc uses a real second shm mapping rather than an alias, and
SessionRings.h:22-28 says that was done so today is not the first time it runs. P6 is
assembly plus a control plane plus a process, not "write a socket transport".
b. The evidence for "P6 is only a transport swap" has EXPIRED. It was bought by P5c, whose
audit found 59 direct memory accesses in a tree that already looked clean. P5e changed
the tree again. So the first package, a6, is a read-only audit that writes no code, and
every contract row that depends on it is marked PENDING a6 rather than decided in
advance.
c. P6 does not get a game running on the phone. ANativeWindow* is meaningless in the child,
and protocol.fbs:186-196's own comment says Android transfers the window out of band -
that band is P12. P6 lands pbuffer / surfaceless / offscreen, which is what HeadlessGL,
the split-equivalent lane and trace replay need, and which is exactly what P6's own exit
gate measures. A real window reaching the server is a named refusal. This gets its own
section because "P6 is done" would otherwise read as "the game runs now".
The contract adds rule G: a role may not name a process-local handle. It extends P5c's
rule E (a role may not name the other role's memory) from memory to identity - EGLDisplay /
EGLSurface / EGLContext / ANativeWindow* / fd number / pid / mapped address either cross as
a token this contract defines or they do not cross, and a descriptor crosses only through
SCM_RIGHTS, where the kernel renumbers it.
What P5e left for P6 gets its own section. The latch semantics are already designed
(ARCHITECTURE.md:504) and are copied unchanged. What is new is that after run-ahead the
client no longer waits while the peer process can DIE: the client holds records that were
published and will never be applied, and Android's freezer suspends the child without
closing anything. So slow and dead must be distinguishable WITHOUT a timeout threshold.
That is P6's only new design; everything else is carriage. It shares a predicate with E1's
outstanding re-specification (ID-122), and the two should be designed together.
Two gates carried over from P5e's lessons: G2 requires integration-spawn's test-name set to
match integration-split's name for name, because a differing set means the lane is quietly
running less; and the arm-proof gate requires every entry to record the child pid and
transport=spawn in its OWN private log - ID-124 established that this kind of false green
really happens, and a spawn lane that actually ran monolith would pass every other gate.
S2's shape must be settled before it is written, and the document says why: E1 is the
cautionary case.
2. The working notes move into the repository (docs/Disaggregated/notes/, 415 .md files)
ROADMAP / CURRENT_STAGE_PROGRESS / MEASUREMENTS cite ruling numbers, audit line numbers and
the provenance of gate figures from ~/w7/notes/, a directory that exists on one machine and
is under no version control. A record cited hundreds of times that lives only locally is not
a record, so it moves in whole, with its directory structure intact.
Only .md moves. Scripts, run logs, census and gate result JSON, patches, APKs and nm dumps
stay where they are: they are evidence DATA rather than documents - large, regenerated per
run, and mostly carrying absolute paths and device serials that mean something only on the
machine that produced them. The mapping and this split are written in
docs/Disaggregated/notes/README.md.
Two exceptions are recorded there too: P6's BRIEF has been promoted to a first-class
document and keeps no copy under notes/, so the two cannot drift apart; and recovered/ holds
material salvaged from failed workflow runs, which may duplicate the like-named phase
directories and is kept because a few of those were the only complete version at the time.
CI's citation lint takes docs/Disaggregated/*.md only (non-recursive), and notes/ is
deliberately outside it: those notes' file:line citations were written against their own
code heads, and resolving them against today's HEAD would fail wholesale - which is not an
error, it is their correct state as a historical record. To check one, use the revision it
declares (--rev).
3. Inconsistencies fixed in passing
- README.md's status line still said P5e was in progress while the stage table already said
closed.
- CURRENT_STAGE_PROGRESS's next-step item 1 still listed the exit gate as pending, though
(a) and (b) were run in the previous commit; rewritten to closed plus the one item that
actually remains (E1).
- ROADMAP's P6 row still had the pre-phase plan in three of its cells; it now carries the
package order, the scope boundary and the two new gates.
Checked with check_doc_citations.py: 125 citations across docs/Disaggregated/*.md, 0 problems.
72 lines
4.6 KiB
Markdown
72 lines
4.6 KiB
Markdown
# Package fb — framebuffers, attachments, images, blit from records (P5e wave 2)
|
|
|
|
Read in this order, all of it: `PACKAGE-PREAMBLE-P5E.md`, `INTEGRATOR-DECISIONS-P5E.md` (ID-86,
|
|
ID-94 are yours), `BRIEF-P5E.md` (§0, §1, §2 "fb", §5, §6 rulings 7, 15, 16), `CONTRACT-P5E.md`
|
|
§5.4, your scout report `scout-S3.md` (all of it), and the framebuffer / image rows of
|
|
`kimi-audit.md` (rows 68-90) — report per row: retired / left barriered / not found. Notes:
|
|
`//wsl.localhost/Arch/home/swung/w7/notes/p5e/`.
|
|
|
|
Your slug is `fb`; your tree is `~/w7/p5e-fb` (branch `p5e/fb`, based on the landed id head, built).
|
|
You CALL tx2's `SyncTextureToBackendByHandle` / `SyncMipmapsToBackendByHandle` (declared by c0e with
|
|
asserting bodies; tx2 writes them in parallel) — code against the declarations and say so in the
|
|
report; the integrator resolves the order at landing.
|
|
|
|
## What "done" means for this family
|
|
|
|
The FBO and RBO twins resolve from the record (`st.BoundFramebuffer[t]` →
|
|
`FramebufferRecords[handle]`), never from the binding slot or the frontend object; the draw-FBO and
|
|
read-FBO attachment lists are keyed by `{record.Fbo, ContentHash}` with surface handles instead of
|
|
borrowed attachment `SharedPtr` slots — this is the one unconditional per-draw live read of your
|
|
family, so it is the package's core; `SyncAttachmentSurface` takes an `MGPSurface`, not a frontend
|
|
attachment; the named blit resolves both endpoints from the two records; images come from
|
|
`BoundShaderImages[]` with `Access` DECODED (ruling 16 / ID-94: the client already encodes it, the
|
|
server comment is stale) and the sweep gate reads applier serials (ruling 7 / ID-86:
|
|
`ShaderImagesSerial`, `TextureShutterSerial`, `ContextSerial`, `g_backendContextGeneration` — keep
|
|
the window/high-water union); `MarkWritableImageBufferTexturesGpuWritten` is deleted under a
|
|
transport (one edit paired with sb's deletion of the backend GPU-write marks — coordinate in the
|
|
reports).
|
|
|
|
## Scope
|
|
|
|
`DirectGLES.cpp`: the doors, the list keys, `SyncReadFramebufferTextureAttachments`, the draw-FBO
|
|
list, the image block (`SyncImageTextureBinding(const MGPImageView&)`, `ResolveShaderImageRecord`
|
|
deleted, the sweep gate), `SyncCurrentFBO*`, `BindCurrentFBO` / `SyncAndBind*` / `ForceBindCurrentFBO`,
|
|
`Clear`'s FBO lines, both blit arms, the detach walk + the new reverse index,
|
|
`SyncRenderbufferObjectToBackend` by handle. `Managers.cpp` / `Managers.h`: the FBO/RBO twin bodies,
|
|
the reverse index (texture → FBO slots) tx2 needs for detach. Tests:
|
|
`MG_Test/Pipe/FramebufferEmitTest.cpp` (the server twin of the existing client case),
|
|
`MG_Test/Pipe/ImageEmitTest.cpp` (the access constants pinned on BOTH sides), and a new
|
|
default-framebuffer-resize re-emit case (your scout verified the resize does re-emit — pin it).
|
|
|
|
## Rulings that bind you
|
|
|
|
- ID-94 / ruling 16: `MGPImageView::Access` IS encoded client-side; move the decode to
|
|
`MGPipeValueTypes.h` (c0e landed the enum) and delete the stale server comment.
|
|
- ID-86 / ruling 7: the sweep gate is the four applier/backend serials, never a backend re-mint
|
|
counter; keep the union of the record window with the image-unit high-water mark.
|
|
- Your scout's open question on `SyncReadFramebufferTextureAttachments` being ungated on the
|
|
framebuffer subsystem bit: its retirement changes behaviour in BOTH arms of the object A/B — name
|
|
the delta in the report and re-baseline that A/B rather than hiding it.
|
|
- The renderbuffer cross-check that runs a client-allocator `HandleOf` on the apply thread under
|
|
split: fix it as part of this package and say whether it was a latent correctness bug.
|
|
|
|
## Red-once (execute, revert, quote)
|
|
|
|
1. `SyncAttachmentSurface` takes the frontend attachment again → `strict` names
|
|
`Fatal{UnmigratedPipeInput, "GetFramebufferBindingSlot"}` on `SnormAttachmentScenario`.
|
|
2. The draw-FBO list key back to the pointer compare → the id guard's `Fatal{RoleViolation, "MGPipeSlots"}`
|
|
(id's hook forces "unbarriered").
|
|
3. Map the image `Access` 1↔2 → `FormatlessImageBakeScenario` / `ImageLoadStoreSsoScenario` red plus
|
|
the unit case.
|
|
4. The named blit back on the frontend objects → `CopyImageLayeredScenario`,
|
|
`LayeredAttachmentShapeScenario`.
|
|
5. Keep the per-point version memo as a second gate → `CrossFrameBufferScenario` / the P4a seam
|
|
scenario must stay green WITHOUT it.
|
|
|
|
## Gate
|
|
|
|
`build`, `unit`, `isplit`, `gens`; `strict` (record the markers that disappeared); `one` on the FBO,
|
|
blit and image scenarios you touch; the seam greps your scout listed must come back silent. Say
|
|
explicitly whether a blit is still barriered after your change (your scout argued it need not be —
|
|
the contract's predicate decides, and ra owns the flip).
|