mirror of
https://github.com/MobileGL-Dev/MobileGL
synced 2026-11-10 11:33:24 +09:00
61 lines
8.3 KiB
Markdown
61 lines
8.3 KiB
Markdown
# CI cleanup log
|
|
|
|
Every removal or replacement of a CI test, gate or lane is logged here with a one-line reason;
|
|
decisions to keep a red case (and fix the code or the tooling instead) are logged too, so the
|
|
next reader can see why a check still exists. Started in P13 (2026-10-06). The rule: a check is
|
|
removed only when it is superseded or no longer relevant (tied to the pull build, or a finished
|
|
migration-phase audit), never to hide a real bug. Goldens change only when the GL spec proves
|
|
them wrong.
|
|
|
|
## Removals
|
|
|
|
| Date | Check | Workflow / job | Reason | Successor |
|
|
|---|---|---|---|---|
|
|
| 2026-10-06 | `build explicit pull runtime control` (the pull `libMobileGL.so`, `-DMOBILEGL_PIPE_PUSH=OFF`) | Test / `build-linux-monolith-control` | P13 W2 retires the pull build: CMake defaults to push and nothing ships pull (ID-P13-1) | the same job builds the push monolith without MG_Remote (the FCL shape); its `runtime_mode_proof --mode monolith` is the zero-MG_Remote-symbol check |
|
|
| 2026-10-06 | `Negative control (pull library)` | Test / `retrace-split` (every leg) | its library was the pull build above | `Negative control (library without a transport)`: same script (renamed `retrace_transport_control.sh`) and evidence sentence, with the push library without MG_Remote; W1 ran both side by side on every leg |
|
|
| 2026-10-06 | `DirectGLES.HandleRecycle.Legacy.*`, `DirectVulkan.HandleRecycle.Legacy.*`, `DirectVulkan.HandleRecycle.AbaControl.*` | Test / integration-gpu (`integration-monolith-control`) | they ran `MOBILEGL_PIPE_PUSH=0`, the pre-handle arm, which P13 W3b removed with `MOBILEGL_PIPE_LEGACY_MEMOS` (ID-P13-3) | `HandleRecycle.Handles.*` and `DirectVulkan.HandleRecycle.AbaControlHandles.*` (the ABA control against the handle arm that ships) stay |
|
|
| 2026-10-06 | `DirectGLES.ResourceSubsystemControl.Off.*`, `DirectGLES.ResourceSubsystemOff.*`, `DirectGLES.ObjectSubsystemControl.{Off,Refused,RefusedTexture}.*` | Test / integration-gpu | they cleared subsystem bits (masks 0x7f / 0x1ff / 0x9ff / 0x5ff) to run legacy arms; since W3b bits 0-13 are fixed on (ID-P13-3) | one named-refusal control per lane, `DirectGLES.SubsystemMaskRefusal.<Lane>`: the same scenario and mask must go red with `Fatal{PipeSubsystemsFixedOn}` naming that mask (`Harness/RefusedMaskControl.cmake`); the `On` lanes now run 0x3fff |
|
|
| 2026-10-06 | `SanityTest`: `DirectGLESSlotTable.{AnArmlessKnobCombinationStopsInsteadOfSkippingTheLane, TheArmlessCasesLeaveTheLogPathAndTheConfigAsTheyFoundThem, EglBringUpUnderTheArmlessKnobPairReturnsInsteadOfStopping}` | Test / unit | they pinned the `MOBILEGL_PIPE_LEGACY_MEMOS=0` + cleared-bit knob pair; the knob is gone and the mask is refused at startup | the SubsystemMaskRefusal controls above |
|
|
| 2026-10-06 | `SanityTest`: `DirectGLESTextureSync.UnitMemoRefusesToDriveATwinFromAnotherTexture` | Test / unit | **not a behaviour gap; the probe cannot run at the shipping mask in the unit lane.** The code it pins - the monolith arm's borrowed-slot unit list and its pairing check - is still live (`UnitTexturesByHandle()` is false on monolith), but at 0x3fff the twin sync below it reads applier records, and `MGPipeApplyResourceCreate` declines in every unit-lane process (`NoP4aConsumer`), so the probe observed nothing (red before W3b at 0x3fff too, green only at P2). | **replaced**, not just removed: `DsaUpdateKeepsTheBoundUnitScenario` asserts the same hazard through public GL at the shipping mask, every lane, both backends (A bound to unit 0, B respecified and filled by name, unit 0 must still sample A's texels and shape). The handle arm's ABA sibling (P5e tx2) stays in SanityTest. Goes away with the borrowed-slot list itself in W4c |
|
|
| 2026-10-06 | `SanityTest`: `DirectGLESTextureSync.AnAttachmentOnlyTexturesParametersReachTheDriverWithNoSamplerView` | Test / unit | **not a behaviour gap.** At 0x3fff the parameter push is record-addressed (`SyncTextureParamsToBackend` reads the texture's applier record; nothing in it consults a sampler view), but the unit lane cannot create that record (`NoP4aConsumer`, as above), so the probe's handle half never had a record to read; its legacy half pinned the pre-handle push that W3b removed | `TextureParamsWithoutASamplerViewScenario` (G9): its four cases take a WHITE-BOX reading of the driver-side parameters before any sample (`TakeTheWhiteBoxReadingBeforeAnySample`, ID-19), at the shipping mask on every lane - the same property, observed where records exist |
|
|
| 2026-10-06 | unit `RenderStateSpans.{ResidualTripWireIsSilentUntilTheApplierOwnsTheBytes, ResidualTripWireHoldsAcrossAVerbClassThatDoesNotPublishTheBlock, ResidualTripWireFiresNamingTheCapability}` and PeerLatchTest's `SetResidualValueStateBlobSize` row | Test / unit | P13 W3c deleted ResidualValueBlock and its applier trip wire (op 46 is a retired, declined row) | integration-verify's new `Negative control A2 (corrupted capability)`: the verify comparator must go red on a corrupted `IsCapabilityEnabled`; `PipeWireCodecTest.ResidualValueBlockCrossesAsItsOwnBlob` now pins that op 46 is declined; `TrackerTest...AClipDistanceEnableReArmsTheResidualBlock` now asserts the capability reaches the applier's block |
|
|
|
|
## Kept after investigation
|
|
|
|
### `minecraft-1.17-main-menu-854` (Test retrace / retrace-split / retrace-verify, APK retrace), 2026-10-06
|
|
|
|
- **Symptom**: every lane, both backends, SSIM 0.0186 against the golden; the frame is Minecraft's
|
|
red loading-screen colour. Local repro on WSL llvmpipe: same SSIM, monolith and inproc.
|
|
- **Root cause**: the trace was captured on an implementation that gave shaders and programs
|
|
**overlapping names** (shader 1 and program 1 live at once, likewise shader 5 / program 5,
|
|
calls 159-209). GL 4.6 core and ES 3.2 §7.1 put shader and program objects in one shared name
|
|
space, so a conformant implementation never hands out such a pair. Since
|
|
`5a0f13fdf` / `168808d1a` (2026-10-01/02) MobileGL advertises `GL_ARB_shader_objects`, and
|
|
apitrace's glretrace then resolves every shader and program name through one ARB handle map
|
|
(`_handleARB_map`): program 1 overwrote shader 1's entry, `glAttachShader(1, 1)` attached a
|
|
program name (GL_INVALID_OPERATION at call 170), the blit program linked without a vertex
|
|
shader, and nothing after it drew.
|
|
- **Classification**: (b) retrace tooling - not a MobileGL bug and not a bad golden. The core
|
|
entry points are typed (`glAttachShader(program, shader)`), so mapping each argument through
|
|
its own type's map is lossless even when the capture's names collide; only the untyped
|
|
`*ObjectARB` handle calls need the shared map.
|
|
- **Fix**: MobileGL-Dev/apitrace `45843686` (branch `mobilegl/android-trace-replay`): typed
|
|
`GLprogram` / `GLshader` arguments resolve through `_program_map` / `_shader_map` first and fall
|
|
back to the ARB handle map only for names created by `glCreate*ObjectARB`; typed creators record
|
|
both maps. Submodule bumped in the same MobileGL commit. Local: 1.17 passes on DirectGLES
|
|
(monolith, inproc) and DirectVulkan (lavapipe).
|
|
- **Decision**: keep the case. With typed mapping it checks GL-level correctness of MobileGL like
|
|
any other fixture; the namespace overlap is a property of the capture that a spec-portable
|
|
replay can absorb.
|
|
- **Side note (not changed)**: MobileGL advertises `GL_ARB_shader_objects` while its
|
|
`glCreateShaderObjectARB` / `glCreateProgramObjectARB` entry points are stubs
|
|
(`MG_Impl/GLImpl/Exporting/Definitions.cpp`). The string was added on purpose for KWin; whether
|
|
to implement the ARB handle entry points is a separate decision.
|
|
|
|
## Infrastructure fixes (no check removed)
|
|
|
|
| Date | What was red | Cause | Fix |
|
|
|---|---|---|---|
|
|
| 2026-10-06 | every `ctest` invocation in integration / verify / split jobs exited 8 after the tests passed (`integration-verify`, `integration-split*`, `integration (inproc)`, `spawn_lane_parity.py`) | `PipeCatalogueSourceRoot.cmake` (a CTest include file) used `if(... IN_LIST ...)`; CTest scripts run without policy CMP0057 on the pinned CMake 3.31.10, so the include errored | use `list(FIND)` instead (`MobileGL/MG_Test/Pipe/CMakeLists.txt`) |
|
|
| 2026-10-06 | `TcpServer.Start.P8aUnlocatedIoBlocks` failed in 0.07 s on `integration (monolith)` | the loopback TCP endpoints (40613, knob lanes 41613-41617) sat inside Linux's ephemeral port range; with thousands of loopback client connections in the lane, an outgoing socket can own the port the supervisor binds | default endpoint moved to 30613 (knob lanes 31613-31617), below 32768 |
|