mirror of
https://github.com/MobileGL-Dev/MobileGL
synced 2026-09-08 04:08:32 +09:00
glFramebufferParameteri, glGetFramebufferParameteriv and their two by-name siblings were all export stubs - the GL_ARB_framebuffer_no_attachments entry points. The stub raises no error and writes nothing, so direct_state_access.framebuffers_get_parameter_errors saw GL_NO_ERROR for all three conditions it checks. FramebufferObject gains the five DEFAULT_* parameters as real state, initialised to GL 4.6 core table 23.24 and bumping the object version on a write like the read buffer does. The getter answers those plus the six derived names - GL_SAMPLES and GL_SAMPLE_BUFFERS from the attachments' sample counts, GL_IMPLEMENTATION_COLOR_READ_FORMAT/_TYPE from the read buffer's internal format, GL_DOUBLEBUFFER true only for the window-system framebuffer, GL_STEREO false because stereo surfaces are not exposed - which is what glGetIntegerv already reports for the bound framebuffer. The pname rules live in ValidateFramebufferParameterPname, and their ORDER is load-bearing: a name outside the table is INVALID_ENUM, and only a name that IS in the table but that the default framebuffer cannot answer is INVALID_OPERATION. Testing the framebuffer kind first would answer INVALID_ENUM for GL_FRAMEBUFFER_DEFAULT_WIDTH on framebuffer zero, which is exactly the third thing the case checks. The by-name forms take zero as the default framebuffer, like the other DSA framebuffer entry points. Rendering to a framebuffer with no attachments is deliberately NOT enabled by this: CheckCompleteness still reports INCOMPLETE_MISSING_ATTACHMENT, because no backend can rasterize one. The state is real and the queries are honest; the draw path is a separate piece of work. Takes framebuffers_get_parameter_errors from failing to passing on both backends, with framebuffers_get_parameters - which passed only because both getters were stubs leaving the CTS's zero-initialised comparands untouched - still passing.
176 lines
6.6 KiB
C++
176 lines
6.6 KiB
C++
// MobileGL - MobileGL/MG_State/GLState/FramebufferState/FramebufferObject.h
|
|
// Copyright (c) 2025-2026 MobileGL-Dev
|
|
// Licensed under the GNU Lesser General Public License v3.0:
|
|
// https://www.gnu.org/licenses/gpl-3.0.txt
|
|
// https://www.gnu.org/licenses/lgpl-3.0.txt
|
|
// SPDX-License-Identifier: LGPL-3.0-only
|
|
// End of Source File Header
|
|
|
|
#pragma once
|
|
#include "MG_Util/Types.h"
|
|
#include <Includes.h>
|
|
#include <MG_State/GLState/TextureState/TextureObject.h>
|
|
#include <MG_State/GLState/RenderbufferState/RenderbufferObject.h>
|
|
|
|
namespace MobileGL {
|
|
enum class FramebufferTarget {
|
|
Draw,
|
|
Read,
|
|
FramebufferTargetCount,
|
|
Unknown = -1
|
|
};
|
|
|
|
enum class FramebufferAttachmentType {
|
|
None,
|
|
|
|
FrontLeft,
|
|
FrontRight,
|
|
BackLeft,
|
|
BackRight,
|
|
|
|
Depth,
|
|
Stencil,
|
|
|
|
Color0,
|
|
Color1,
|
|
Color2,
|
|
Color3,
|
|
Color4,
|
|
Color5,
|
|
Color6,
|
|
Color7,
|
|
Color8,
|
|
Color9,
|
|
Color10,
|
|
Color11,
|
|
Color12,
|
|
Color13,
|
|
Color14,
|
|
Color15,
|
|
Color16,
|
|
Color17,
|
|
Color18,
|
|
Color19,
|
|
Color20,
|
|
Color21,
|
|
Color22,
|
|
Color23,
|
|
Color24,
|
|
Color25,
|
|
Color26,
|
|
Color27,
|
|
Color28,
|
|
Color29,
|
|
Color30,
|
|
Color31,
|
|
ColorMax = Color31,
|
|
|
|
FramebufferAttachmentTypeCount,
|
|
Unknown = -1
|
|
};
|
|
|
|
namespace MG_State::GLState {
|
|
class FramebufferAttachmentObject {
|
|
public:
|
|
explicit FramebufferAttachmentObject(const SharedPtr<MG_State::GLState::ITextureObject>& texture,
|
|
TextureUploadTarget textureUploadTarget,
|
|
Int level = 0, Int layer = 0, Bool layered = false);
|
|
explicit FramebufferAttachmentObject(const SharedPtr<RenderbufferObject>& renderbuffer);
|
|
explicit FramebufferAttachmentObject(Bool IsValid = true);
|
|
|
|
Bool IsTexture() const;
|
|
Bool IsRenderbuffer() const;
|
|
Bool IsEmpty() const;
|
|
const SharedPtr<MG_State::GLState::ITextureObject>& GetTexture() const;
|
|
const SharedPtr<RenderbufferObject>& GetRenderbuffer() const;
|
|
Int GetTextureLevel() const;
|
|
Int GetTextureLayer() const;
|
|
Bool IsLayered() const;
|
|
TextureUploadTarget GetTextureUploadTarget() const;
|
|
Bool IsComplete() const;
|
|
IntVec3 GetSize() const;
|
|
Bool IsValid() const;
|
|
|
|
private:
|
|
SharedPtr<MG_State::GLState::ITextureObject> m_texture = nullptr;
|
|
SharedPtr<RenderbufferObject> m_renderbuffer = nullptr;
|
|
TextureUploadTarget m_textureUploadTarget = TextureUploadTarget::Unknown;
|
|
Int m_textureLevel = 0;
|
|
Int m_textureLayer = 0;
|
|
Bool m_layered = false;
|
|
Bool m_isValid = true;
|
|
};
|
|
|
|
class FramebufferObject {
|
|
public:
|
|
static constexpr Uint MAX_DRAW_BUFFERS = 8;
|
|
|
|
using TargetEnum = FramebufferTarget;
|
|
using FramebufferAttachmentObjectArray =
|
|
Array<FramebufferAttachmentObject,
|
|
static_cast<SizeT>(FramebufferAttachmentType::FramebufferAttachmentTypeCount)>;
|
|
using FramebufferAttachmentArray = Array<FramebufferAttachmentType, MAX_DRAW_BUFFERS>;
|
|
using FramebufferAttachmentVersionArray =
|
|
Array<Uint16, static_cast<SizeT>(FramebufferAttachmentType::FramebufferAttachmentTypeCount)>;
|
|
|
|
FramebufferObject(Uint externalIndex);
|
|
|
|
void AttachTexture(FramebufferAttachmentType type, const SharedPtr<ITextureObject>& texture,
|
|
TextureUploadTarget textureUploadTarget = TextureUploadTarget::Unknown, int level = 0,
|
|
int layer = 0, Bool layered = false);
|
|
void AttachRenderbuffer(FramebufferAttachmentType type, const SharedPtr<RenderbufferObject>& renderbuffer);
|
|
void Detach(FramebufferAttachmentType type);
|
|
const FramebufferAttachmentObject& GetAttachment(FramebufferAttachmentType type) const;
|
|
const FramebufferAttachmentObjectArray& GetAllAttachmentObjects() const;
|
|
Bool CheckCompleteness() const;
|
|
// aka. `buffer` as in glDrawBuffers/glReadBuffers
|
|
void SetDrawBuffer(Uint index, FramebufferAttachmentType buffer);
|
|
const FramebufferAttachmentArray& GetDrawBuffers() const;
|
|
void SetReadBuffer(FramebufferAttachmentType buf);
|
|
FramebufferAttachmentType GetReadBuffer() const { return m_readBuffer; }
|
|
|
|
// GL_ARB_framebuffer_no_attachments state (GL 4.6 core table 23.24). The shape a
|
|
// framebuffer with no attachments would rasterize at; all zero / FALSE until set.
|
|
Int GetDefaultWidth() const { return m_defaultWidth; }
|
|
Int GetDefaultHeight() const { return m_defaultHeight; }
|
|
Int GetDefaultLayers() const { return m_defaultLayers; }
|
|
Int GetDefaultSamples() const { return m_defaultSamples; }
|
|
Bool GetDefaultFixedSampleLocations() const { return m_defaultFixedSampleLocations; }
|
|
void SetDefaultWidth(Int value);
|
|
void SetDefaultHeight(Int value);
|
|
void SetDefaultLayers(Int value);
|
|
void SetDefaultSamples(Int value);
|
|
void SetDefaultFixedSampleLocations(Bool value);
|
|
|
|
FramebufferAttachmentVersionArray GetAllFramebufferAttachmentVersions() const {
|
|
return m_attachmentVersions;
|
|
}
|
|
|
|
Uint16 GetObjectVersion() const { return m_objectVersion; }
|
|
|
|
Uint GetExternalIndex() const;
|
|
Bool IsDefaultFramebuffer() const { return m_externalIndex == 0; }
|
|
|
|
private:
|
|
void BumpAttachmentVersion(FramebufferAttachmentType type);
|
|
|
|
const Uint m_externalIndex = 0;
|
|
FramebufferAttachmentObjectArray m_attachmentObjects;
|
|
FramebufferAttachmentVersionArray m_attachmentVersions;
|
|
|
|
FramebufferAttachmentArray m_drawBuffers; // Probably no versioning needed for this, just check equality
|
|
FramebufferAttachmentType m_readBuffer = FramebufferAttachmentType::None;
|
|
|
|
Int m_defaultWidth = 0;
|
|
Int m_defaultHeight = 0;
|
|
Int m_defaultLayers = 0;
|
|
Int m_defaultSamples = 0;
|
|
Bool m_defaultFixedSampleLocations = false;
|
|
|
|
// This version will bump when draw/read buffer changes (by `glDrawBuffer(s)`/`glReadBuffer`)
|
|
Uint16 m_objectVersion = 0;
|
|
};
|
|
|
|
} // namespace MG_State::GLState
|
|
} // namespace MobileGL
|