Files
MobileGL/docs/Disaggregated/notes/p5/p5-results/j0-v3.md
T
swung0x48 aba329cc53 [Docs] (Disaggregated): P6's plan and contract draft; the working notes move from a local directory into the repository
Two things land together: the plan and contract draft P6 needs before it starts, and the
working notes that until now existed on exactly one machine.

1. P6's plan and contract draft (neither started; not one line of code)

     docs/Disaggregated/P6-SPAWN-PLAN.md      the package plan
     docs/Disaggregated/P6-CONTRACT-DRAFT.md  the contract draft (moves to
                                              MG_Remote/CONTRACT-P6.md when c6 lands)

   The three findings that mattered, all written into the documents:

   a. P6 is SMALLER than its roadmap cell suggests. The transport primitives are already in
      the tree and already tested: SocketDoorbell including hangup detection and the two
      lost-wakeup fences (Doorbell.cpp:211-360, four cases in FdPassingTest), SCM_RIGHTS fd
      passing, ShmSegment::Adopt, and the SurfaceOp / WindowKind schema already defined in
      protocol.fbs. inproc uses a real second shm mapping rather than an alias, and
      SessionRings.h:22-28 says that was done so today is not the first time it runs. P6 is
      assembly plus a control plane plus a process, not "write a socket transport".

   b. The evidence for "P6 is only a transport swap" has EXPIRED. It was bought by P5c, whose
      audit found 59 direct memory accesses in a tree that already looked clean. P5e changed
      the tree again. So the first package, a6, is a read-only audit that writes no code, and
      every contract row that depends on it is marked PENDING a6 rather than decided in
      advance.

   c. P6 does not get a game running on the phone. ANativeWindow* is meaningless in the child,
      and protocol.fbs:186-196's own comment says Android transfers the window out of band -
      that band is P12. P6 lands pbuffer / surfaceless / offscreen, which is what HeadlessGL,
      the split-equivalent lane and trace replay need, and which is exactly what P6's own exit
      gate measures. A real window reaching the server is a named refusal. This gets its own
      section because "P6 is done" would otherwise read as "the game runs now".

   The contract adds rule G: a role may not name a process-local handle. It extends P5c's
   rule E (a role may not name the other role's memory) from memory to identity - EGLDisplay /
   EGLSurface / EGLContext / ANativeWindow* / fd number / pid / mapped address either cross as
   a token this contract defines or they do not cross, and a descriptor crosses only through
   SCM_RIGHTS, where the kernel renumbers it.

   What P5e left for P6 gets its own section. The latch semantics are already designed
   (ARCHITECTURE.md:504) and are copied unchanged. What is new is that after run-ahead the
   client no longer waits while the peer process can DIE: the client holds records that were
   published and will never be applied, and Android's freezer suspends the child without
   closing anything. So slow and dead must be distinguishable WITHOUT a timeout threshold.
   That is P6's only new design; everything else is carriage. It shares a predicate with E1's
   outstanding re-specification (ID-122), and the two should be designed together.

   Two gates carried over from P5e's lessons: G2 requires integration-spawn's test-name set to
   match integration-split's name for name, because a differing set means the lane is quietly
   running less; and the arm-proof gate requires every entry to record the child pid and
   transport=spawn in its OWN private log - ID-124 established that this kind of false green
   really happens, and a spawn lane that actually ran monolith would pass every other gate.
   S2's shape must be settled before it is written, and the document says why: E1 is the
   cautionary case.

2. The working notes move into the repository (docs/Disaggregated/notes/, 415 .md files)

   ROADMAP / CURRENT_STAGE_PROGRESS / MEASUREMENTS cite ruling numbers, audit line numbers and
   the provenance of gate figures from ~/w7/notes/, a directory that exists on one machine and
   is under no version control. A record cited hundreds of times that lives only locally is not
   a record, so it moves in whole, with its directory structure intact.

   Only .md moves. Scripts, run logs, census and gate result JSON, patches, APKs and nm dumps
   stay where they are: they are evidence DATA rather than documents - large, regenerated per
   run, and mostly carrying absolute paths and device serials that mean something only on the
   machine that produced them. The mapping and this split are written in
   docs/Disaggregated/notes/README.md.

   Two exceptions are recorded there too: P6's BRIEF has been promoted to a first-class
   document and keeps no copy under notes/, so the two cannot drift apart; and recovered/ holds
   material salvaged from failed workflow runs, which may duplicate the like-named phase
   directories and is kept because a few of those were the only complete version at the time.

   CI's citation lint takes docs/Disaggregated/*.md only (non-recursive), and notes/ is
   deliberately outside it: those notes' file:line citations were written against their own
   code heads, and resolving them against today's HEAD would fail wholesale - which is not an
   error, it is their correct state as a historical record. To check one, use the revision it
   declares (--rev).

3. Inconsistencies fixed in passing

   - README.md's status line still said P5e was in progress while the stage table already said
     closed.
   - CURRENT_STAGE_PROGRESS's next-step item 1 still listed the exit gate as pending, though
     (a) and (b) were run in the previous commit; rewritten to closed plus the one item that
     actually remains (E1).
   - ROADMAP's P6 row still had the pre-phase plan in three of its cells; it now carries the
     package order, the scope boundary and the two new gates.

Checked with check_doc_citations.py: 125 citations across docs/Disaggregated/*.md, 0 problems.
2026-09-18 23:31:39 -04:00

68 lines
4.1 KiB
Markdown

# j0 round 3 — ID-62 / N-1 skipped selections
Branch `p5/j0`, round range `68d8ef9f..cc20de37`.
Commit `cc20de37da90c52dd57756f032b99160cda233d3`:
`[Fix] (IntegrationTest): reject skipped split control selections`.
Immediately before committing, identity was `Swung0x48 <swung0x48@outlook.com>`.
Single-line commit message, no attribution trailer.
Read PACKAGE-PREAMBLE, BRIEF §13/R-16, ID-53/60/61/62, and the review's N-1.
Only five files changed: the existing log helper, split controls, stub, private-log smoke extension,
and control red-check. No C++, CMake, workflow, local-gate, or library changes. G1 unaffected;
no new binary comparison or build is claimed. Round-2 wiring in `control_smoke_test.sh` already
executes the extension and is unchanged. No other worktree, LFS, or adb was touched.
## Result contract
Each knob run now writes fresh CTest `--output-junit` XML. The helper compares testcase names
with the selected runtime entries in `--show-only=json-v1`, before inspecting CTest's exit code
or any private Fatal. It detects skips using JUnit `<skipped/>`, not transcript status lines.
Any selected skip fails with this exact message (the helper adds its usual prefix):
```
SplitLogPaths FAILED: E1 control: the knob killed the pre-flight, not the entry - 1 selected entries skipped
```
Absent/duplicate testcase records and `notrun`/`disabled` statuses fail separately as
`E1 control: <n> selected entries did not run`. Every selected record must then have CTest
`status="fail"` and a `<failure>` element. The real unit JUnit confirms CTest uses `fail`.
The same result checks apply to E3(a), under its own name; its diagnostic remains the existing
persistent-map scenario assertion. E1 now requires the expected Fatal in EVERY selected private
file, replacing the first-match return. A pre-flight Fatal plus a skipped selection cannot pass.
The all-skipped baseline's existing disarmed warning is unchanged, as requested.
## Verification and red-once
- Actual CI smoke entry point: **9 + 10 = 19 passed, 0 failed**, rc 0.
- New extension cases: skipped selection with a private Fatal and CTest rc 0; `notrun`; absent
result; two failed entries with only one private Fatal; wrong Fatal. Skip and non-run cases
assert their full exact message with `grep -qFx`.
- `scripts/ci/redcheck_control_smoke_test.sh`: **rc 0**, final
`P5_T1_CONTROL_SMOKE_REDCHECK_OK`. Existing evidence-removal checks remain intact.
- **I made it red once by removing only the skip check:** the mechanised runner replaces
`if skipped:` with `if False:`. The actual smoke command exits **1**, prints
`NOT OK skipped-selection: control must report FAILED for its own reason`, and
`CONTROL_SMOKE_TEST_FAILED`. It rejects the fallback `did not run` message as the wrong cause.
The runner restores the helper and both control scripts through its trap.
- `ctest --test-dir build-split -L unit --no-tests=error -j 14 --output-on-failure
--output-junit /home/swung/w7/p5-j0-v3-unit.xml`, with
`GLIBC_TUNABLES=glibc.malloc.tcache_count=0`: **1985 selected, 1974 passed, 1 failed,
10 skipped**, rc 8. Sole failure remains c1's
`PipeWireCodecTest.NoReplyIsWrittenForARowTheCatalogueGivesNoReplySlot`.
- `ctest --test-dir build-split --show-only=json-v1` and the production ownership helper:
**21 runtime entries, 21 distinct private paths**.
- `git diff --check`: clean. Final repository clean, submodule links **off**.
## Evidence and handoff
Retained under `/home/swung/w7/`: `p5-j0-v3-smoke.log`, `p5-j0-v3-redcheck.log`
(includes the executed red-once output), `p5-j0-v3-unit.log`, `p5-j0-v3-unit.xml`, and
`p5-j0-v3-split.json`. The empty `p5-j0-v3-tmp` scratch directory was removed; smoke scratch
children were automatically deleted. Earlier reports' cited evidence is untouched.
Integrator: merge this final j0 head separately into the joint tree and rerun the real controls.
This fixes the control's classification; it does not move the Fatal out of pre-flight or claim
the joint E1 runtime gate passed. N-1's pre-flight behavior must now produce a named control
failure. All selected E1 entries must actually fail and carry their own expected private Fatal
before the control can pass. No C++ change.