Files
MobileGL/docs/archive/notes/p5/p5-results/j0-v3.md
T

68 lines
4.1 KiB
Markdown

# j0 round 3 — ID-62 / N-1 skipped selections
Branch `p5/j0`, round range `68d8ef9f..cc20de37`.
Commit `cc20de37da90c52dd57756f032b99160cda233d3`:
`[Fix] (IntegrationTest): reject skipped split control selections`.
Immediately before committing, identity was `Swung0x48 <swung0x48@outlook.com>`.
Single-line commit message, no attribution trailer.
Read PACKAGE-PREAMBLE, BRIEF §13/R-16, ID-53/60/61/62, and the review's N-1.
Only five files changed: the existing log helper, split controls, stub, private-log smoke extension,
and control red-check. No C++, CMake, workflow, local-gate, or library changes. G1 unaffected;
no new binary comparison or build is claimed. Round-2 wiring in `control_smoke_test.sh` already
executes the extension and is unchanged. No other worktree, LFS, or adb was touched.
## Result contract
Each knob run now writes fresh CTest `--output-junit` XML. The helper compares testcase names
with the selected runtime entries in `--show-only=json-v1`, before inspecting CTest's exit code
or any private Fatal. It detects skips using JUnit `<skipped/>`, not transcript status lines.
Any selected skip fails with this exact message (the helper adds its usual prefix):
```
SplitLogPaths FAILED: E1 control: the knob killed the pre-flight, not the entry - 1 selected entries skipped
```
Absent/duplicate testcase records and `notrun`/`disabled` statuses fail separately as
`E1 control: <n> selected entries did not run`. Every selected record must then have CTest
`status="fail"` and a `<failure>` element. The real unit JUnit confirms CTest uses `fail`.
The same result checks apply to E3(a), under its own name; its diagnostic remains the existing
persistent-map scenario assertion. E1 now requires the expected Fatal in EVERY selected private
file, replacing the first-match return. A pre-flight Fatal plus a skipped selection cannot pass.
The all-skipped baseline's existing disarmed warning is unchanged, as requested.
## Verification and red-once
- Actual CI smoke entry point: **9 + 10 = 19 passed, 0 failed**, rc 0.
- New extension cases: skipped selection with a private Fatal and CTest rc 0; `notrun`; absent
result; two failed entries with only one private Fatal; wrong Fatal. Skip and non-run cases
assert their full exact message with `grep -qFx`.
- `scripts/ci/redcheck_control_smoke_test.sh`: **rc 0**, final
`P5_T1_CONTROL_SMOKE_REDCHECK_OK`. Existing evidence-removal checks remain intact.
- **I made it red once by removing only the skip check:** the mechanised runner replaces
`if skipped:` with `if False:`. The actual smoke command exits **1**, prints
`NOT OK skipped-selection: control must report FAILED for its own reason`, and
`CONTROL_SMOKE_TEST_FAILED`. It rejects the fallback `did not run` message as the wrong cause.
The runner restores the helper and both control scripts through its trap.
- `ctest --test-dir build-split -L unit --no-tests=error -j 14 --output-on-failure
--output-junit /home/swung/w7/p5-j0-v3-unit.xml`, with
`GLIBC_TUNABLES=glibc.malloc.tcache_count=0`: **1985 selected, 1974 passed, 1 failed,
10 skipped**, rc 8. Sole failure remains c1's
`PipeWireCodecTest.NoReplyIsWrittenForARowTheCatalogueGivesNoReplySlot`.
- `ctest --test-dir build-split --show-only=json-v1` and the production ownership helper:
**21 runtime entries, 21 distinct private paths**.
- `git diff --check`: clean. Final repository clean, submodule links **off**.
## Evidence and handoff
Retained under `/home/swung/w7/`: `p5-j0-v3-smoke.log`, `p5-j0-v3-redcheck.log`
(includes the executed red-once output), `p5-j0-v3-unit.log`, `p5-j0-v3-unit.xml`, and
`p5-j0-v3-split.json`. The empty `p5-j0-v3-tmp` scratch directory was removed; smoke scratch
children were automatically deleted. Earlier reports' cited evidence is untouched.
Integrator: merge this final j0 head separately into the joint tree and rerun the real controls.
This fixes the control's classification; it does not move the Fatal out of pre-flight or claim
the joint E1 runtime gate passed. N-1's pre-flight behavior must now produce a named control
failure. All selected E1 entries must actually fail and carry their own expected private Fatal
before the control can pass. No C++ change.